Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmetal.cmake:modify libmetal headers according to Makefile reference #11119

Closed
wants to merge 1 commit into from
Closed

libmetal.cmake:modify libmetal headers according to Makefile reference #11119

wants to merge 1 commit into from

Conversation

xuxin930
Copy link
Contributor

@xuxin930 xuxin930 commented Nov 3, 2023 •
edited
Loading

Summary

Fix undefined issues in libmetal cmake build

Impact

this patch should fix #10401 issue

Testing

CI build

@xuxin930 xuxin930 marked this pull request as ready for review November 3, 2023 03:35
@xiaoxiang781216
Copy link
Contributor

@xuxin930 but the ci fail to build.

@raiden00pl
Copy link
Contributor

this patch should fix #10401 issue

This issue is about broken make build.
If we modify cmake to be the same as make - should I assume that cmake will also be broken? :)

@xuxin930 xuxin930 marked this pull request as draft November 5, 2023 04:28
@xuxin930 xuxin930 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raiden00pl raiden00pl Awaiting requested review from raiden00pl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAMP behaves differently for make and cmake when compiling for armv7-m
3 participants
@xuxin930 @xiaoxiang781216 @raiden00pl