Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix save and restore in GitHub cache action for MacOS build #7834

Merged
merged 1 commit into from
Dec 9, 2022
Merged

ci: Fix save and restore in GitHub cache action for MacOS build #7834

merged 1 commit into from
Dec 9, 2022

Conversation

gustavonihei
Copy link
Contributor

Summary

This PR intends to fix the cache saving and restoration of the prebuilt binaries in MacOS CI build.

Impact

Fixes #7636.

Testing

CI build pass and successfully completing the Post Restore Tools Cache build stage:
image

@xiaoxiang781216
Copy link
Contributor

@gustavonihei look like #7832 has some issue:
https://github.com/apache/nuttx/actions/runs/3652785945/jobs/6171593013

@pkarashchenko
Copy link
Contributor 

2022-12-08T23:02:51.2864262Z   Building NuttX...
2022-12-08T23:03:36.6916656Z riscv64-unknown-elf-ld: /tools/riscv64-unknown-elf-gcc/bin/../lib/gcc/riscv64-unknown-elf/10.2.0/libgcc.a(div.o): ABI is incompatible with that of the selected emulation:
2022-12-08T23:03:36.6917760Z   target emulation `elf64-littleriscv' does not match `elf32-littleriscv'
2022-12-08T23:03:36.6918858Z riscv64-unknown-elf-ld: failed to merge target specific data of file /tools/riscv64-unknown-elf-gcc/bin/../lib/gcc/riscv64-unknown-elf/10.2.0/libgcc.a(div.o)
2022-12-08T23:03:36.7460126Z riscv64-unknown-elf-ld: /github/workspace/sources/nuttx/staging/libc.a(lib_flsl.o): in function `flsl':
2022-12-08T23:03:36.7461291Z /github/workspace/sources/nuttx/libs/libc/string/lib_flsl.c:61: undefined reference to `__clzsi2'
2022-12-08T23:03:36.7613336Z make[1]: *** [Makefile:154: nuttx] Error 1
2022-12-08T23:03:36.7621942Z make: *** [tools/Unix.mk:516: nuttx] Error 2

Most probably can be due to recent RISCV toolchain update

@xiaoxiang781216
Copy link
Contributor

Try to fix with #7835

@xiaoxiang781216
Copy link
Contributor

let's ignore the ci broken, and merge this patch first.

@xiaoxiang781216 xiaoxiang781216 merged commit 6576be9 into apache:master Dec 9, 2022
@xiaoxiang781216
Copy link
Contributor

@gustavonihei does macOS ci fail relate to this patch?
https://github.com/apache/nuttx/actions/runs/3655290845/jobs/6176522471

This was referenced Dec 9, 2022
Merged
Merged
@jerpelea jerpelea added this to To-Add in Release Notes - 12.0.0 Dec 29, 2022
@jerpelea jerpelea moved this from To-Add to Not Applicable in Release Notes - 12.0.0 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btashton btashton btashton approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 12.0.0
Not Applicable
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: MacOS tool cache is broken leading to longer build times
4 participants
@gustavonihei @xiaoxiang781216 @pkarashchenko @btashton