-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CONFIG_FS_WRITABLE #484
Labels
enhancement
New feature or request
Comments
Agree, especially the saved code size without CONFIG_FS_WRITABLE is very smalled. |
Merged
Merged
Fix in apps: apache/nuttx-apps#131 |
cwespressif
pushed a commit
to cwespressif/incubator-nuttx
that referenced
this issue
Apr 3, 2024
…nline-rebase [T3PW] [mainline rebase] rebase Nuttx mainline code w2410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is kind of a useless configuration variable that occurs in many places and adds a lot of complexity and makes debug a lot more difficult.
It makes debug more difficult because it is not consistently set and requires a lot of debug time before you finally figure out "I need to set CONFIG_FS_WRITABLE.
In most places affected by CONFIG_FS_WRITABLE, the configuration option is stupid: Who needs read-only MMC or read-only SmartFS. Just not a useful thing. And many places that do need CONFIG_FS_WRITABLE do not automatically set it. Like drivers/mtd/ftl.c. In that case, you can debug for most of the day before you finally figure out why the you can't access flash via character driver (which is a really common configuration for resource limited platforms).
It is hard to imagine a platform that supports a file system but has no writing enabled. I could imagine a system with only ROMFS or only CROMFS. But that is really about it and, in those cased, CONFIG_FS_WRITABLE has no effect. I am not aware of any such case, but that would be the only kind of platform that would suffer from the change.
But my opinion is that in the bigger picture, NuttX would be cleaner, less complex, and more usable with CONFIG_FS_WRITABLE removed.
The text was updated successfully, but these errors were encountered: