Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Configure Warnings #386

Closed
patacongo opened this issue Feb 26, 2020 · 2 comments · Fixed by #897
Closed

Windows Configure Warnings #386

patacongo opened this issue Feb 26, 2020 · 2 comments · Fixed by #897
Labels
bug Something isn't working

Comments

@patacongo
Copy link
Contributor

For the past few weeks, I have bee seen new warnings when I configure any board under Cygwin or MSYS. There are the warning I see right now on MSYS (same warnings on Cygwin):

$ tools/configure.sh -g z20x:sdboot
  Copy files
  Select CONFIG_HOST_WINDOWS=y
  Select CONFIG_WINDOWS_MSYS=y
  Refreshing...
.config:54:warning: override: reassigning to symbol HOST_WINDOWS
.config:54:warning: override: HOST_WINDOWS changes choice state

I think the first is caused by

# CONFIG_HOST_WINDOWS is not set

followed by

CONFIG_HOST_WINDOWS=y

That is invalid because CONFIG_HOST_WINDOWS is both disable and enabled. The correctly solution would be either (2) use kconfig-tweak which will to both or (2) use sed to expicitly remove CONFIG_HOST_WINDOWS before adding CONFIG_HOST_WINDOWS=y
@patacongo patacongo added the bug Something isn't working label Mar 5, 2020
@patacongo patacongo mentioned this issue Mar 7, 2020
Merged
@patacongo patacongo mentioned this issue Apr 27, 2020
Closed
@patacongo
Copy link
Contributor Author

Issue #386 is still a problem. I think this occurs when you configure on a Windows Cygwin or MSYS but the defconfig is Linux. It will try to convert the configure to Windows Cygwin or MSY but the make oldconfig then generates warnings.

This was not a problem in the past because kconfig-tweak was used to modify defconfig files. That was replaced with sed. kconfig-tweak is safe and always generates a correct configuration. sed is not safe and creates invalid defconfig configurations that generate errors when we try to produce the .config (via make olddefconfig)

patacongo pushed a commit to patacongo/nuttx that referenced this issue Apr 27, 2020
@gregory-nutt
tools/sethost.sh: Correct error in setting a different host.
ff93c70 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.  NOTE:  It is never necessary to disable options with kconfig-tweak.  If you enable a choice selection, it is smart enough to automatically disable the other options.  These greately reduces the size and complexity of sethost.sh.

This change resolves issue apache#386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
@patacongo patacongo mentioned this issue Apr 27, 2020
Merged
@patacongo patacongo linked a pull request Apr 27, 2020 that will close this issue
tools/sethost.sh: Correct error in setting a different host. #897
Merged
patacongo pushed a commit to patacongo/nuttx that referenced this issue Apr 27, 2020
@gregory-nutt
tools/sethost.sh: Correct error in setting a different host.
93a286d 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.  NOTE:  It is never necessary to disable options with kconfig-tweak.  If you enable a choice selection, it is smart enough to automatically disable the other options.  These greately reduces the size and complexity of sethost.sh.

This change resolves issue apache#386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
patacongo pushed a commit to patacongo/nuttx that referenced this issue Apr 27, 2020
@gregory-nutt
tools/sethost.sh: Correct error in setting a different host.
9648f03 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.

This change resolves issue apache#386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
@patacongo
Copy link
Contributor Author

NOTE: The macOS builds will fail. The kconfig-frontends were not built correctly. They need to build kconfig-frontends which must be enabled on the configure command line.

Ouss4 pushed a commit that referenced this issue Apr 27, 2020
@gregory-nutt @Ouss4
tools/sethost.sh: Correct error in setting a different host.
100bd74 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.

This change resolves issue #386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
patacongo pushed a commit to patacongo/nuttx that referenced this issue Apr 27, 2020
@gregory-nutt
tools/sethost.sh: Correct error in setting a different host.
a0134b7 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.

This change resolves issue apache#386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
@patacongo patacongo mentioned this issue Apr 27, 2020
Merged
Ouss4 pushed a commit that referenced this issue Apr 27, 2020
@gregory-nutt @Ouss4
tools/sethost.sh: Correct error in setting a different host.
725bdfb 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.

This change resolves issue #386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
raiden00pl pushed a commit to raiden00pl/nuttx that referenced this issue May 2, 2020
@gregory-nutt @raiden00pl
tools/sethost.sh: Correct error in setting a different host.
53a7313 
In an older PR, the standard kconfig-tweak calls were replaced with sed edit.  This is an incorrect change and results in invalid configurations.  This change restores the use of kconfig-tweak and always generates correct configurations.

This change resolves issue apache#386

sed edits do not handle all of the dependencies correct and generates invalid configurations.  Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration.  Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as:

   $ tools/configure.sh -c stm32f4discovery:nsh
      Copy files
      Select CONFIG_HOST_WINDOWS=y
      Select CONFIG_WINDOWS_CYGWIN=y
      Refreshing...
    .config:62:warning: override: reassigning to symbol HOST_WINDOWS
    .config:62:warning: override: HOST_WINDOWS changes choice state

Those warnings are eliminated by this changed.

Tested by repeatedly doing:

  tools/configure.sh -c stm32f4discovery:nsh
cwespressif pushed a commit to cwespressif/incubator-nuttx that referenced this issue Apr 3, 2024
@royfengsss
Merge pull request apache#386 from midokura/feature/t3pw-dev-test-cas…
c5218da 
…e-porting

Feature/t3pw dev test case porting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools/sethost.sh: Correct error in setting a different host. patacongo/nuttx
1 participant
@patacongo