-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Configure Warnings #386
Comments
Issue #386 is still a problem. I think this occurs when you configure on a Windows Cygwin or MSYS but the defconfig is Linux. It will try to convert the configure to Windows Cygwin or MSY but the make oldconfig then generates warnings. This was not a problem in the past because kconfig-tweak was used to modify defconfig files. That was replaced with sed. kconfig-tweak is safe and always generates a correct configuration. sed is not safe and creates invalid defconfig configurations that generate errors when we try to produce the .config (via make olddefconfig) |
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. NOTE: It is never necessary to disable options with kconfig-tweak. If you enable a choice selection, it is smart enough to automatically disable the other options. These greately reduces the size and complexity of sethost.sh. This change resolves issue apache#386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. NOTE: It is never necessary to disable options with kconfig-tweak. If you enable a choice selection, it is smart enough to automatically disable the other options. These greately reduces the size and complexity of sethost.sh. This change resolves issue apache#386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. This change resolves issue apache#386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
NOTE: The macOS builds will fail. The kconfig-frontends were not built correctly. They need to build kconfig-frontends which must be enabled on the configure command line. |
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. This change resolves issue #386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. This change resolves issue apache#386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. This change resolves issue #386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
In an older PR, the standard kconfig-tweak calls were replaced with sed edit. This is an incorrect change and results in invalid configurations. This change restores the use of kconfig-tweak and always generates correct configurations. This change resolves issue apache#386 sed edits do not handle all of the dependencies correct and generates invalid configurations. Most defconfig files specify Linux by default, so you will only see the effect of the corruped configuration when sethost changes changes to a different configuration. Then, when 'make olddefconfig' is subsequentyly run, the corruption in the defconfig file is reflected by warnings such as: $ tools/configure.sh -c stm32f4discovery:nsh Copy files Select CONFIG_HOST_WINDOWS=y Select CONFIG_WINDOWS_CYGWIN=y Refreshing... .config:62:warning: override: reassigning to symbol HOST_WINDOWS .config:62:warning: override: HOST_WINDOWS changes choice state Those warnings are eliminated by this changed. Tested by repeatedly doing: tools/configure.sh -c stm32f4discovery:nsh
…e-porting Feature/t3pw dev test case porting
For the past few weeks, I have bee seen new warnings when I configure any board under Cygwin or MSYS. There are the warning I see right now on MSYS (same warnings on Cygwin):
I think the first is caused by
followed by
That is invalid because CONFIG_HOST_WINDOWS is both disable and enabled. The correctly solution would be either (2) use kconfig-tweak which will to both or (2) use sed to expicitly remove CONFIG_HOST_WINDOWS before adding CONFIG_HOST_WINDOWS=y
The text was updated successfully, but these errors were encountered: