Remove the unnecessary math.h inclusion #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antmerlino Could you try this patch? |
xiaoxiang781216
force-pushed
the
math
branch
3 times, most recently
from
0128124
to
298f2be
Compare
@xiaoxiang781216 The build worked now. Thanks! |
xiaoxiang781216
force-pushed
the
math
branch
4 times, most recently
from
d7babdd
to
fe336e6
Compare
or move from header file to source file since math.h doesn't always exist Signed-off-by: Xiang Xiao <[email protected]>
|
@xiaoxiang781216 I saw you were still working on this - I assume to get past CI. Is this good to merge now? |
|
Yes, it is ready for merge. |
antmerlino
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the problem reported here: #3456
Impact
Reduce the dependence on math.h
Testing
Pass CI