Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer build libc stdio without math.h #3456

Closed
antmerlino opened this issue Apr 6, 2021 · 0 comments · Fixed by #3511
Closed

Can no longer build libc stdio without math.h #3456

antmerlino opened this issue Apr 6, 2021 · 0 comments · Fixed by #3511

Comments

@antmerlino
Copy link
Contributor

antmerlino commented Apr 6, 2021

I had a very simple configuration for a board that worked at some point and I ran into build errors because it was looking for math.h and I didn't have CONFIG_LIBM on.

Looks like this change d17b963 moved types and subsequent includes.

Do we want to fix this, or do we want to require that users provide a math.h, either via CONFIG_LIBM, toolchain, or otherwise?

If we did want to fix, I think we need to:

  1. guard every place in libc that uses float/double with CONFIG_LIBC_FLOATINGPOINT
  2. guard the include with either CONFIG_LIBC_FLOATINGPOINT or CONFIG_LIBM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant