nxstyle: No error reported on long right hand comments

[patacongo]

The following does not generate a long line error. It should, of course:

/****************************************************************************
 * junk.c
 ****************************************************************************/

/****************************************************************************
 * Included Files
 ****************************************************************************/

#include <stdint.h>

/****************************************************************************
 * Pre-processor Definitions
 ****************************************************************************/

#define A_PREPROCESSOR_DEFINITION 0  /* With a a very long, single-line right hand comment.  No error is reported by nxstyle. */

/****************************************************************************
 * Private Types
 ****************************************************************************/

struct a_struct_s
{
  uint8_t f; /* This is a very long line in a single-line, right-hand comment.   No error is reported by nxstyle. */
};

/****************************************************************************
 * Public Functions
 ****************************************************************************/

Related: Issue #652

[patacongo]

It is not recommended that this issue be fixed quickly. There are many header files, especially under arch/ that have long lines of this type that would then be reported. We can't afford that workload now.

There are a couple of places where this should be reported in nxstyle.c. One of them has already been fixed, but intentionally disabled for that reason:

2422           /* Check for long lines
2423            *
2424            * REVISIT:  Long line checks suppressed on right hand comments
2425            * for now.  This just prevents a large number of difficult-to-
2426            * fix complaints that we would have otherwise.
2427            */
2428
2429           if (m > g_maxline && !rhcomment)
2430             {
2431               if (g_file_type == C_SOURCE)
2432                 {
2433                   ERROR("Long line found", lineno, m);
2434                 }
2435               else if (g_file_type == C_HEADER)
2436
2437                 {
2438                   WARN("Long line found", lineno, m);
2439                 }
2440             }
2441         }