-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure python environment and install esptool #18
Conversation
cibuild.sh
Outdated
@@ -24,6 +24,11 @@ apps=$WD/../apps | |||
tools=$WD/../tools | |||
prebuilt=$WD/../prebuilt | |||
|
|||
# Python User Env | |||
PIP_USER=yes | |||
PYTHONUSERBASE=$WD/../pylocal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about change the path to:
PYTHONUSERBASE=$prebuilt/pylocal
like other tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@@ -118,6 +123,7 @@ function xtensa-esp32-gcc-toolchain { | |||
rm xtensa-esp32-elf-gcc8_2_0-esp32-2019r1-rc2-linux-amd64.tar | |||
fi | |||
xtensa-esp32-elf-gcc --version | |||
pip install esptool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check some file doesn't exist before install esptool like we check $prebuilt/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip
performs this check and will skip downloading if it already exists so I think we are good.
@xiaoxiang781216 Will this suffice to fix 437 ? |
Yes, I thinks so. |
I am validating this docker image against the the testing system with the xtensa config enabled. I'll comment with a successful run. |
Signed-off-by: Brennan Ashton <[email protected]>
@Ouss4 @xiaoxiang781216 This does not fix that issue. My CI run shows the IDF_PATH not being set so it cannot find the bootloader. It does move past the issue where the esptool.py does not exist. I am kind of thinking that we at least for the CI generate these two binaries ahead of time that way we do not have to pull in the whole IDF system.
|
I think I have the bootloader and partition table sorted out at least for the docker build, which I want to figure out before fixing up the ci shell script. But I think there might be something wrong with the esp32 build. It never generated the
|
Maybe a different solution is to wrap the whole post build script with a binary config similar to CXD56xx and not worry about it when we are just building. |
I'm about 90% of the way now so I think I would rather just finish it. I suspect we have other binary blobs like wifi that we might want compiled in to other tests. One of my later goals is to get artifacts from builds that run on QEMU and then feed them into that. Right now I have a BLOBDIR variable that can be set to provide these to the build. |
Ok I have a build working now. I'll need to update this a fair amount, but also submit a PR against the OS as well first. |
Lets get the Github Actions version sorted out #20 and then I can look at how to integrate it into the |
@Ouss4 and @btashton, please look at this PR: |
Thanks @xiaoxiang781216 |
This configures a the python user installation environment and then installs the
esptool
dependency. Should resolve the nightly build issue and enable us to more easily install python dependencies in the ci scripts.