This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Python string formatting #21136
Merged
Python string formatting #21136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankaj
requested review from
szha,
aaronmarkham,
nswamy and
eric-haibin-lin
as code owners
|
Hey @hankaj , Thanks for submitting the PR
CI supported jobs: [clang, miscellaneous, windows-gpu, edge, unix-cpu, centos-gpu, centos-cpu, website, windows-cpu, unix-gpu, sanity] Note: |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-review
anko-intel
suggested changes
Sep 12, 2022
| 'Please train the models and run inference again' % bucket_name) | ||
| raise Exception("No trained models found in S3 bucket : %s for this file. " | ||
| "Please train the models and run inference again" % bucket_name) | ||
| logging.error('No trained models found in S3 bucket : {} for this file. ' |
There was a problem hiding this comment.
What is the reason to have to different approaches than in line 110?
here {bucket_name} seems to be more readable
There was a problem hiding this comment.
In CI I got the error that you should not use f-strings in messages of logging functions.
Comment on lines
124
to
127
| logging.error('No trained models found in S3 bucket : {} for this file. ' | ||
| 'Please train the models and run inference again'.format(bucket_name)) | ||
| raise Exception(f"No trained models found in S3 bucket : {bucket_name} for this file. " | ||
| "Please train the models and run inference again") |
There was a problem hiding this comment.
Same comment as above
Suggested change
| logging.error('No trained models found in S3 bucket : {} for this file. ' | |
| 'Please train the models and run inference again'.format(bucket_name)) | |
| raise Exception(f"No trained models found in S3 bucket : {bucket_name} for this file. " | |
| "Please train the models and run inference again") | |
| logging.error(f'No trained models found in S3 bucket : {bucket_name} for this file. ' | |
| 'Please train the models and run inference again') | |
| raise Exception(f"No trained models found in S3 bucket : {bucket_name} for this file. " | |
| "Please train the models and run inference again") |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [sanity] |
|
Jenkins CI successfully triggered : [sanity] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [sanity, centos-cpu, windows-cpu, miscellaneous, windows-gpu, unix-cpu, clang, unix-gpu, centos-gpu, website, edge] |
mseth10
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
anko-intel
approved these changes
Sep 14, 2022
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes most of the
%-formatting in python to f-strings (orformat()in some cases).According to Python documentation f-strings and
format()are preferred to the%-formatting (which was used in Python 2).