This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Requantize scale fix #21100
Merged
Requantize scale fix #21100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @DominikaJedynak , Thanks for submitting the PR
CI supported jobs: [unix-gpu, windows-cpu, unix-cpu, clang, centos-gpu, edge, centos-cpu, windows-gpu, miscellaneous, website, sanity] Note: |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [clang] |
|
Jenkins CI successfully triggered : [clang] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [centos-gpu, edge] |
|
Jenkins CI successfully triggered : [centos-gpu, edge] |
mseth10
added
pr-awaiting-testing
bartekkuncer
approved these changes
Jul 19, 2022
mseth10
added
pr-work-in-progress
|
@mxnet-bot run ci [centos-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu] |
mseth10
added
pr-awaiting-testing
bgawrych
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the problem occurring when one of the values used to calculate data_range happened to be INT32_MIN what was causing overflow when calling abs(INT32_MIN).
PR also contains small refactor to clarify that we multiply sum_scale *2 to get rid of u8_reorder_scale applied before.