Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Refactor fc_sum_fuse #21077

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Refactor fc_sum_fuse #21077

merged 6 commits into from
Jul 7, 2022

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Jun 21, 2022 •
edited
Loading

Description

This change aims to simplify fc and sum fuse property implementation.

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, edge, clang, centos-gpu, miscellaneous, unix-cpu, sanity, windows-cpu, centos-cpu, windows-gpu, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Jun 21, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [website, edge, centos-gpu, unix-cpu, centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, website, centos-cpu, centos-gpu, unix-cpu]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [miscellaneous, edge, unix-gpu, centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, unix-gpu, centos-cpu, edge]

@bartekkuncer bartekkuncer marked this pull request as ready for review June 23, 2022 09:11
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 23, 2022
anko-intel
anko-intel reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@anko-intel anko-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make such reviews on innersource

src/operator/subgraph/dnnl/dnnl_fc_sum_fuse_property.h Show resolved Hide resolved
src/operator/subgraph/dnnl/dnnl_fc_sum_fuse_property.h Show resolved Hide resolved
src/operator/subgraph/dnnl/dnnl_fc_sum_fuse_property.h Show resolved Hide resolved
src/operator/subgraph/dnnl/dnnl_fc_sum_fuse_property.h Outdated Show resolved Hide resolved
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [edge, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, edge]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 23, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [edge, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, edge]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 24, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 28, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Jul 6, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 6, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [clang,edge, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [clang, unix-cpu, edge]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 6, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2022
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2022
@bgawrych bgawrych merged commit e36c9f0 into apache:master Jul 7, 2022
@bartekkuncer bartekkuncer deleted the fc_refactor branch July 7, 2022 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anko-intel anko-intel anko-intel approved these changes

@bgawrych bgawrych bgawrych approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bartekkuncer @mxnet-bot @anko-intel @bgawrych @mseth10