Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

oneDNN FullyConnected weight caching & refactor #21047

Merged
merged 16 commits into from
Jul 6, 2022
Merged

oneDNN FullyConnected weight caching & refactor #21047

merged 16 commits into from
Jul 6, 2022

Conversation

bgawrych
Copy link
Contributor

Description

Caching mechanism for FC
BRGEMM always enabled for int8
Refactor Forward function using smaller functions

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, edge, centos-cpu, website, unix-gpu, windows-cpu, centos-gpu, unix-cpu, sanity, clang, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 31, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 3, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 15, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 15, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 15, 2022
@mseth10 mseth10 added the pr-awaiting-review PR is waiting for code review label Jun 27, 2022
@DominikaJedynak
Copy link
Contributor

@DominikaJedynak please check if I merged correctly your type fix

Yes, it seems to be ok.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 29, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 30, 2022
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, windows-cpu, centos-cpu, miscellaneous, clang, unix-gpu, centos-gpu, edge, windows-gpu, sanity, unix-cpu]

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 30, 2022
@bgawrych
Copy link
Contributor Author

bgawrych commented Jul 4, 2022

@mxnet-bot run ci [windows-gpu, unix-gpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, windows-gpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jul 4, 2022
@bgawrych
Copy link
Contributor Author

bgawrych commented Jul 5, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 5, 2022
@bgawrych bgawrych merged commit 84b1626 into apache:master Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@DominikaJedynak DominikaJedynak DominikaJedynak approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bgawrych @mxnet-bot @DominikaJedynak @bartekkuncer @mseth10