Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] porting #19756 to v1.x #19757

Merged
merged 1 commit into from
Jan 19, 2021
Merged

[v1.x] porting #19756 to v1.x #19757

merged 1 commit into from
Jan 19, 2021

Conversation

samskalicky
Copy link
Contributor

Description

Porting #19756 to v1.x

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-gpu, centos-cpu, unix-cpu, edge, miscellaneous, sanity, clang, unix-gpu, windows-cpu, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 15, 2021
prats13bag
prats13bag approved these changes Jan 19, 2021
View reviewed changes
Copy link

@prats13bag prats13bag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samskalicky samskalicky merged commit de17b5b into apache:v1.x Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prats13bag prats13bag prats13bag approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samskalicky @mxnet-bot @prats13bag @lanking520