This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[LICENSE] [v1.x] Change intgemm to a submodule instead of fetch. #19407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the issue that LICENSE refered to 3rdparty/intgemm/LICENSE which was not present in the source because it was downloaded: https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E
Hey @kpuatamazon , Thanks for submitting the PR
CI supported jobs: [edge, windows-gpu, unix-gpu, windows-cpu, clang, sanity, unix-cpu, miscellaneous, website, centos-cpu, centos-gpu] Note: |
16 tasks
@mxnet-bot run ci [unix-cpu, unix-gpu] Testing is really flaky today https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-19407/1/pipeline
|
Jenkins CI successfully triggered : [unix-cpu, unix-gpu] |
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Dec 8, 2020
…che#19407) * Change intgemm to a submodule instead of fetch. This resolves the issue that LICENSE refered to 3rdparty/intgemm/LICENSE which was not present in the source because it was downloaded: https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E * Exclude intgemm from license header check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves the issue that
LICENSE
referred to3rdparty/intgemm/LICENSE
which was not present in the source because it was downloaded:https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E
Checklist
Essentials
Changes
CMakeLists.txt
3rdparty
Note
Sibling #19406 addresses v1.8.x. This is v1.x. master is coming.