Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix nightly large_vector test caused by incorrect with_seed path #18178

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix nightly large_vector test caused by incorrect with_seed path #18178

merged 1 commit into from
Apr 29, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Apr 27, 2020 •
edited
Loading

Description

NightlyTestforBinaries for 1.7.x and master revealed error with with_seed path
Fixing it in master & will cherry-pick the fix to 1.7.x branch
http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/master/670/pipeline
http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.7.x/1/pipeline

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:

@ciyongch @access2rohit @apeforest

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, centos-gpu, windows-cpu, unix-gpu, centos-cpu, edge, clang, miscellaneous, website, unix-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@marcoabreu
Copy link
Contributor

How is removing something without replacement a fix? Please elaborate - apparently this was put in place for a reason.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Apr 28, 2020
@ChaiBapchya
Copy link
Contributor Author

Testing this on : http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/nightly_chai/detail/fix_large_vector_nightly/1/pipeline [triggering the failing nightly build on this branch fix on CI Prod]
Will delete the pipeline once PR merged.

@leezu leezu merged commit 7145250 into apache:master Apr 29, 2020
@ciyongch
Copy link
Contributor

@ChaiBapchya please help to backport this fix to v1.7.x branch as well, thanks!

ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request May 1, 2020
@ChaiBapchya
Fix nightly large_vector test caused by incorrect with_seed path (apa…
bccbf0a 
…che#18178)
@ChaiBapchya
Copy link
Contributor Author

ChaiBapchya commented May 1, 2020 •
edited
Loading

@ciyongch Backported to 1.7.x #18220
Pl review/merge
Thanks

@ChaiBapchya ChaiBapchya deleted the fix_large_vector_nightly branch May 1, 2020 22:52
leezu pushed a commit that referenced this pull request May 4, 2020
@ChaiBapchya
Cherrypick Fix nightly large_vector test caused by incorrect with_see…
295e939 
…d path (#18178) (#18220)

* Fix nightly large_vector test caused by incorrect with_seed path (#18178)

* pylint astroid sanity issue
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@ChaiBapchya @AntiZpvoh
Fix nightly large_vector test caused by incorrect with_seed path (apa…
6dd64bc 
…che#18178)
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Sep 20, 2020
@ChaiBapchya
Fix nightly large_vector test caused by incorrect with_seed path (apa…
03f53e7 
…che#18178)
samskalicky pushed a commit that referenced this pull request Sep 24, 2020
@ChaiBapchya @access2rohit
[v1.x] Nightly Large Tensor test cherrypicks (#19194)
2b055b7 
* fixing batch_norm and layer_norm for large tensors (#17805)

Co-authored-by: Rohit Kumar Srivastava <[email protected]>

* Fix nightly large_vector test caused by incorrect with_seed path (#18178)

* add back the missing environment function

Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Sep 24, 2020
@ChaiBapchya @access2rohit
[v1.x] Nightly Large Tensor test cherrypicks (apache#19194)
373dcca 
* fixing batch_norm and layer_norm for large tensors (apache#17805)

Co-authored-by: Rohit Kumar Srivastava <[email protected]>

* Fix nightly large_vector test caused by incorrect with_seed path (apache#18178)

* add back the missing environment function

Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
@ChaiBapchya ChaiBapchya mentioned this pull request Sep 24, 2020
Merged
6 tasks
samskalicky pushed a commit that referenced this pull request Sep 24, 2020
@ChaiBapchya @access2rohit
[v1.x] Nightly Large Tensor test cherrypicks (#19194) (#19215)
7c9046a 
* fixing batch_norm and layer_norm for large tensors (#17805)

Co-authored-by: Rohit Kumar Srivastava <[email protected]>

* Fix nightly large_vector test caused by incorrect with_seed path (#18178)

* add back the missing environment function

Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Co-authored-by: Rohit Kumar Srivastava <[email protected]>

Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu approved these changes

@access2rohit access2rohit access2rohit left review comments

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ChaiBapchya @mxnet-bot @marcoabreu @ciyongch @leezu @access2rohit @lanking520