This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix description of setting Debug build type for cmake #18114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting CMAKE_BUILD_TYPE in config.cmake not works properly as the config file is read too late. Instead, ask user to setup build type from the command line to generate proper cache file.
|
Hey @anko-intel , Thanks for submitting the PR
CI supported jobs: [clang, windows-gpu, centos-cpu, centos-gpu, website, sanity, edge, unix-gpu, windows-cpu, unix-cpu, miscellaneous] Note: |
leezu
approved these changes
Apr 20, 2020
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
Setting CMAKE_BUILD_TYPE in config.cmake not works properly as the config file is read too late. Instead, ask user to setup build type from the command line to generate proper cache file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting CMAKE_BUILD_TYPE in config.cmake not works properly as the
config file is read too late. Instead, ask user to setup build type
from the command line to generate proper cache file.
It fixes #18091
Thanks @leezu
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.