Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add gelu fuse ops #18082

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Add gelu fuse ops #18082

merged 6 commits into from
Apr 17, 2020

Conversation

MoisesHer
Copy link
Contributor

@MoisesHer MoisesHer commented Apr 16, 2020

Description

This PR adds into elementwise fused-operators LeakyReLU:gelu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • In pointwise fusion pass, set as fusion-compatible both LeakyReLU and _backward_LeakyReLU if activation type is in the provided list (only "gelu" for now)
  • In the fused-ops code generator, include functions for LeakyReLU:gelu and _backward_LeakyReLU:gelu (they are equivalent to mshadow_op.h version)
  • Included test into tests/python/gpu/test_fusion.py

Comments

@mxnet-bot
Copy link

Hey @MoisesHer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, unix-cpu, edge, miscellaneous, centos-cpu, windows-gpu, unix-gpu, windows-cpu, clang, centos-gpu, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@MoisesHer
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, centos-gpu]

@ptrendx ptrendx merged commit b01d1dc into apache:master Apr 17, 2020
MoisesHer added a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 17, 2020
* Add LeakyReLU:Gelu (fwd and bwd) to fused ops

* Add test LeakyReLU:gelu

* cpplint

* fix lint

* fix bug SQRT_2 using constant memory

* add comments
ptrendx pushed a commit that referenced this pull request Apr 18, 2020
* Add LeakyReLU:Gelu (fwd and bwd) to fused ops

* Add test LeakyReLU:gelu

* cpplint

* fix lint

* fix bug SQRT_2 using constant memory

* add comments
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
* Add LeakyReLU:Gelu (fwd and bwd) to fused ops

* Add test LeakyReLU:gelu

* cpplint

* fix lint

* fix bug SQRT_2 using constant memory

* add comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants