Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Cherry-pick of #17995 and #17937 to 1.x branch #18041

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Apr 13, 2020

Description

Cherry pick of #17995 and #17937 to 1.x branch.

FYI, @ciyongch

@mxnet-bot
Copy link

Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, edge, website, windows-gpu, unix-gpu, miscellaneous, windows-cpu, clang, centos-cpu, centos-gpu, unix-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ptrendx
Copy link
Member Author

ptrendx commented Apr 13, 2020

@ChaiBapchya seems that v1.x branch needs the backport of your fix to TLS handhsake problem.

@ciyongch
Copy link
Contributor

@ptrendx Thanks for the notice, I've already added these two PR in the roadmap, and will update the status later.

@ChaiBapchya
Copy link
Contributor

Added : #18044
@ptrendx thanks for pointing out!

@TaoLv TaoLv added the v1.x Targeting v1.x branch label Apr 14, 2020
* Fix ElemwiseSum for more than 4 inputs

* Added test
* Fix for handling of negative axis, begin and end in fusion of slice ops

* Added test
@ptrendx
Copy link
Member Author

ptrendx commented Apr 15, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@DickJC123 DickJC123 self-requested a review April 18, 2020 01:51
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for inclusion in 1.7

@ptrendx ptrendx merged commit 814530d into apache:v1.x Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.x Targeting v1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants