Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x #18016

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

connorgoggins
Copy link
Contributor

Description

I noticed that recently my nightly build pipeline for v1.x (drawing on the v1.x branch from the main repository as its source) began to fail. I hadn't changed any code, but I noticed that the error being generated stemmed from an RVM version issue that I fixed in master by pinning the dependency version as part of my General Version Dropdown PR. Since v1.x doesn't include changes to master, I realized that I would need to incorporate this fix in v1.x as well in order to get my nightly builds (or any website builds on this branch) to pass.

I tested my fix for this branch via my v1.x nightly build Jenkins pipeline, and it passed with my changes.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • M ci/docker/Dockerfile.build.ubuntu_cpu_jekyll

@mxnet-bot
Copy link

Hey @connorgoggins , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-cpu, unix-gpu, centos-gpu, sanity, unix-cpu, edge, windows-gpu, website, windows-cpu, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Apr 10, 2020
@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [Website]

@TaoLv TaoLv added the v1.x Targeting v1.x branch label Apr 10, 2020
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for fixing it.
Wanted clarification on why 1.x branch started failing now after your website PRs got merged?
That'll explain why #17993 PR also saw this failure with 0 code change between the subsequent commits.
@aaronmarkham maybe you can help.

@connorgoggins
Copy link
Contributor Author

connorgoggins commented Apr 10, 2020

@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.

Just to clarify, my PRs did not introduce this error - they actually fixed it (in master). This was an issue introduced in the past (since the dependency wasn't pinned for install but a specific version was required for runtime) that didn't surface until RVM released a new version of the package. While adding the version dropdown, I noticed the problem in master and added a fix to my PR. The reason the other branches are failing is because I only added the fix for master, and the other branches (which also rely on the RVM package) did not have the benefit of my fix.

@ChaiBapchya
Copy link
Contributor

@connorgoggins looks like 2.6.3 breaks the build
Hence the master branch was updated to 2.6.5
#17918 (comment)

@connorgoggins
Copy link
Contributor Author

connorgoggins commented Apr 10, 2020

@ChaiBapchya 2.6.3 doesn't break the build. What breaks the build is not specifying a version of RVM. Either 2.6.3 or 2.6.5 is valid as long as the version installed is the same as the version required for the run.

@ChaiBapchya
Copy link
Contributor

Thanks for the clarification!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review v1.x Targeting v1.x branch Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants