Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[mkldnn]Mkldnn bn opt backport from master to 1.7x #18009

Merged
merged 4 commits into from
Apr 15, 2020
Merged

[mkldnn]Mkldnn bn opt backport from master to 1.7x #18009

merged 4 commits into from
Apr 15, 2020

Conversation

rongzha1
Copy link
Contributor

Description

[mkldnn]Mkldnn bn opt backport from master to 1.7x

@TaoLv @pengzhao-intel @ciyongch

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @rongzha1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, centos-gpu, unix-cpu, unix-gpu, windows-cpu, clang, website, edge, miscellaneous, sanity, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor

Assume you're going to backport this PR to v1.x branch, but currently you choose master branch. Please double check the target branch.

@leezu leezu changed the base branch from master to v1.x April 10, 2020 01:20
@leezu
Copy link
Contributor

leezu commented Apr 10, 2020

I edited the target branch accordingly

@rongzha1 rongzha1 closed this Apr 10, 2020
@rongzha1
Copy link
Contributor Author

I edited the target branch accordingly

thank you very much.

I have just re-pr it to 1.7.x a minites ago

@rongzha1 rongzha1 reopened this Apr 10, 2020
@rongzha1
Copy link
Contributor Author

@mxnet-bot run ci [all]

@ciyongch
Copy link
Contributor

Adding this to 1.7.0 roadmap #16864

@TaoLv TaoLv added the v1.x Targeting v1.x branch label Apr 10, 2020
@rongzha1
Copy link
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [clang, edge, unix-gpu, unix-cpu, centos-cpu, windows-cpu, centos-gpu, windows-gpu, website, miscellaneous, sanity]

@rongzha1
Copy link
Contributor Author

@mxnet-bot run ci unix-gpu

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@rongzha1
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and merging

@pengzhao-intel pengzhao-intel merged commit 50d6d7d into apache:v1.x Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.x Targeting v1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants