Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Implement np.random.pareto backward #17607

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Implement np.random.pareto backward #17607

merged 1 commit into from
Feb 24, 2020

Conversation

D-Roberts
Copy link
Contributor

@D-Roberts D-Roberts commented Feb 15, 2020 •
edited
Loading

Description

Add backward implementation to np.random.pareto.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add random pareto backward implementation; add random pareto grad test.
  • Small change to test of np.random.weibull - test ValueError for a=0.

@D-Roberts D-Roberts requested a review from szha as a code owner February 15, 2020 20:32
xidulu
xidulu approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 added the Numpy label Feb 17, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Feb 17, 2020
@haojin2 haojin2 self-assigned this Feb 17, 2020
haojin2
haojin2 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when CI passes

numpy automation moved this from In progress to Reviewer approved Feb 20, 2020
@D-Roberts D-Roberts force-pushed the pareto_backward branch 2 times, most recently from d54dfe7 to b0106db Compare February 21, 2020 16:18
@haojin2 haojin2 merged commit a6ab49f into apache:master Feb 24, 2020
numpy automation moved this from Reviewer approved to Done Feb 24, 2020
@haojin2
Copy link
Contributor

haojin2 commented Feb 24, 2020

@D-Roberts Merged, thanks for your contribution!

anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@D-Roberts @anirudh2290
Implement np.random.pareto backward (apache#17607)
fae563b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 approved these changes

@xidulu xidulu xidulu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@D-Roberts @haojin2 @xidulu