Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] Implement Weibull backward #17590

Merged
merged 1 commit into from
Feb 15, 2020
Merged

[numpy] Implement Weibull backward #17590

merged 1 commit into from
Feb 15, 2020

Conversation

D-Roberts
Copy link
Contributor

@D-Roberts D-Roberts commented Feb 13, 2020 •
edited
Loading

Description

Add backward implementation to np.random.weibull.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add back; add test of grad.
  • Restrict a>0.

@D-Roberts D-Roberts requested a review from szha as a code owner February 13, 2020 23:40
@D-Roberts D-Roberts force-pushed the weib_back branch 4 times, most recently from 565dd9a to 968a2c2 Compare February 14, 2020 03:08
@haojin2 haojin2 self-assigned this Feb 14, 2020
@haojin2 haojin2 added the Numpy label Feb 14, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Feb 14, 2020
@haojin2
Copy link
Contributor

haojin2 commented Feb 14, 2020

@D-Roberts Thanks for your contribution! Please let @xidulu and/or me know when you think this PR is ready for a review.

@D-Roberts D-Roberts changed the title [WIP][numpy] Implement Weibull backward [numpy] Implement Weibull backward Feb 15, 2020
@D-Roberts
Copy link
Contributor Author

@haojin2 @xidulu Ready for review.

xidulu
xidulu approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit b6b1de0 into apache:master Feb 15, 2020
numpy automation moved this from In progress to Done Feb 15, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@D-Roberts
Implement Weibull backward (apache#17590)
7f68105
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@D-Roberts @anirudh2290
Implement Weibull backward (apache#17590)
f91edea
@D-Roberts D-Roberts deleted the weib_back branch December 21, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xidulu xidulu xidulu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@D-Roberts @haojin2 @xidulu