This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Update Win CI scripts to use syntax compatible with Win2019 server PS. #17526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephevans
force-pushed
the
win2019_fixes
branch
from
4ac3d69
to
59c892e
Compare
leezu
approved these changes
Feb 8, 2020
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
…er powershell. (apache#17526) Co-authored-by: Leonard Lausen <[email protected]>
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
…er powershell. (apache#17526) Co-authored-by: Leonard Lausen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our win CI scripts are failing on Windows 2019 Server. The newer PowerShell on this Win2019 Server gives a 'False' return code for the '$?' variable if any output is written to stderr, where previous versions did not. This PR changes the variable used for checking return code of last run program ($LastExitCode instead of $ ?) which works in all versions of PowerShell.
Sorry, had to recreate this PR.