Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] Add np.random.pareto and np.random.power #17517

Merged
merged 2 commits into from
Feb 6, 2020
Merged

[numpy] Add np.random.pareto and np.random.power #17517

merged 2 commits into from
Feb 6, 2020

Conversation

D-Roberts
Copy link
Contributor

@D-Roberts D-Roberts commented Feb 4, 2020 •
edited
Loading

Description

  • Add numpy.random.pareto and numpy.random.power.
  • Add one test for pareto, power and weibull random ops.
  • Remove previous np.random.weibull test.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@D-Roberts D-Roberts requested a review from szha as a code owner February 4, 2020 23:15
@D-Roberts D-Roberts changed the title [numpy] Add np.random.pareto and np.random.power [WIP][numpy] Add np.random.pareto and np.random.power Feb 5, 2020
@reminisce reminisce added the Numpy label Feb 5, 2020
@D-Roberts D-Roberts changed the title [WIP][numpy] Add np.random.pareto and np.random.power [numpy] Add np.random.pareto and np.random.power Feb 5, 2020
haojin2
haojin2 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 91c4516 into apache:master Feb 6, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@D-Roberts
[numpy] Add np.random.pareto and np.random.power (apache#17517)
2bb4f81 
* Add np.random.pareto and np.random.power; add one test for pareto, power, weibull

* Remove previous Weibull test
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@D-Roberts @anirudh2290
[numpy] Add np.random.pareto and np.random.power (apache#17517)
4831345 
* Add np.random.pareto and np.random.power; add one test for pareto, power, weibull

* Remove previous Weibull test
@D-Roberts D-Roberts deleted the rand_pp branch December 21, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reminisce reminisce reminisce left review comments

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@D-Roberts @reminisce @haojin2