Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy]Add numpy.random.weibull operator #17505

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Conversation

D-Roberts
Copy link
Contributor

@D-Roberts D-Roberts commented Feb 1, 2020

Description

Add numpy operator mx.np.random.weibull. This is the numpy random number generator for the Weibull distribution (via inversion).
Weibull distribution can be used similarly to Gumbel as a "Weibull trick".
https://arxiv.org/pdf/1706.04161.pdf

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@D-Roberts D-Roberts requested a review from szha as a code owner February 1, 2020 22:57
@D-Roberts D-Roberts changed the title Add numpy weibull operator [numpy]Add numpy weibull operator Feb 1, 2020
@D-Roberts D-Roberts changed the title [numpy]Add numpy weibull operator [numpy]Add numpy.random.weibull operator Feb 1, 2020
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@haojin2 could you help retrigger the CI and review the code?

@D-Roberts
Copy link
Contributor Author

@xidulu @haojin2 I've retriggered CI a couple of times, there is still some unrelated issue.

@haojin2 haojin2 self-assigned this Feb 3, 2020
@haojin2 haojin2 added the Numpy label Feb 3, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Feb 3, 2020
@haojin2
Copy link
Contributor

haojin2 commented Feb 3, 2020

@D-Roberts Thanks for your contribution, I've re-triggered the unix-gpu build. Recently it's been quite flaky, let's see how this trial goes.

@D-Roberts
Copy link
Contributor Author

@haojin2 Thanks, seems all checks passed and I fixed the conflicts.

@reminisce reminisce merged commit de30aa5 into apache:master Feb 4, 2020
numpy automation moved this from In progress to Done Feb 4, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@D-Roberts D-Roberts deleted the rand_ops branch December 21, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants