Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add np.product #17489

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Add np.product #17489

merged 1 commit into from
Feb 20, 2020

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jan 30, 2020

Description

by adding alias _np_product to _np_prod

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add alias and doc
  • Add interoperability test

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Jan 30, 2020
@haojin2 haojin2 requested a review from szha as a code owner January 30, 2020 21:21
@haojin2 haojin2 self-assigned this Jan 30, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Jan 30, 2020
numpy automation moved this from In progress to Reviewer approved Feb 6, 2020
@haojin2 haojin2 force-pushed the np_product branch 5 times, most recently from ee6433b to e727d92 Compare February 15, 2020 08:39
@haojin2 haojin2 merged commit 23ff424 into apache:master Feb 20, 2020
numpy automation moved this from Reviewer approved to Done Feb 20, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants