Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add npx.gather_nd #17477

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Add npx.gather_nd #17477

merged 2 commits into from
Feb 7, 2020

Conversation

zheyuye
Copy link
Contributor

@zheyuye zheyuye commented Jan 30, 2020

Description

A temporary solution of #17327 to support the gather_nd operation for mx.np.ndarray in Numpy Extensions.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Additional operation supporting gather_nd for mx.np.ndarray

Comments

@sxjscience

@haojin2 haojin2 merged commit 371beed into apache:master Feb 7, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants