This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Implement remaining nn_activation ops in opperf #17475
Merged
apeforest
merged 7 commits into
apache:master
from
connorgoggins:implement_nn_activation_ops
Feb 12, 2020
Merged
Implement remaining nn_activation ops in opperf #17475
apeforest
merged 7 commits into
apache:master
from
connorgoggins:implement_nn_activation_ops
Feb 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiBapchya
reviewed
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but pending the results
- All Opperf
- Category
CPU & GPU
Thanks!
Group of operator test - all NN Activation ops (CPU) GPU results coming soon. |
@mxnet-label-bot add [pr-awaiting-review] |
connorgoggins
requested review from
aaronmarkham,
anirudh2290,
eric-haibin-lin,
marcoabreu,
nswamy and
szha
as code owners
February 4, 2020 01:34
Incorrect way to rebase @connorgoggins First get your master branch updated
Once your fork master is sync'ed with remote master, rebase your branch on master
Let me know if this works! |
connorgoggins
force-pushed
the
implement_nn_activation_ops
branch
3 times, most recently
from
February 5, 2020 19:58
a21c378
to
f11ba22
Compare
ChaiBapchya
approved these changes
Feb 6, 2020
connorgoggins
force-pushed
the
implement_nn_activation_ops
branch
from
February 6, 2020 18:38
f11ba22
to
c0d73ed
Compare
connorgoggins
force-pushed
the
implement_nn_activation_ops
branch
from
February 7, 2020 01:01
c0d73ed
to
b20ea9c
Compare
access2rohit
approved these changes
Feb 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Retriggered the failing builds
connorgoggins
force-pushed
the
implement_nn_activation_ops
branch
from
February 10, 2020 21:16
b20ea9c
to
16c8ca5
Compare
…zed function, added Softmax, SoftmaxActivation, softmin, and Activation ops
…zed function, added Softmax, SoftmaxActivation, softmin, and Activation ops
connorgoggins
force-pushed
the
implement_nn_activation_ops
branch
from
February 12, 2020 08:19
16c8ca5
to
c6fc7e3
Compare
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
* Refactored individual run_performance_test calls into single generalized function, added Softmax, SoftmaxActivation, softmin, and Activation ops * Refactored individual run_performance_test calls into single generalized function, added Softmax, SoftmaxActivation, softmin, and Activation ops * Fixed variable names * Added newline at end of file for consistency * Addressed NN Basic PR comment * Dropped unnecessary custom_args * Removed unique_ops
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* Refactored individual run_performance_test calls into single generalized function, added Softmax, SoftmaxActivation, softmin, and Activation ops * Refactored individual run_performance_test calls into single generalized function, added Softmax, SoftmaxActivation, softmin, and Activation ops * Fixed variable names * Added newline at end of file for consistency * Addressed NN Basic PR comment * Dropped unnecessary custom_args * Removed unique_ops
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves to implement the remaining operators from the nn_activation category in opperf. To achieve this, I refactored the preexisting individual
run_performance_test
calls (for the four operators that had already been implemented) into a single generalized function call torun_op_benchmarks
. I also implemented Softmax, SoftmaxActivation, softmin, and Activation ops, which are also called via therun_op_benchmarks
function.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
Tested on c5.18xl & p2.16xl w/ubuntu 16.04 and Mac OS with:
run_activation_operators_benchmarks
- runs all activation ops on default dataopperf.py
(full run of all ops)