Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Don't unnecessarily relicense FindCUDAToolkit.cmake #17334

Merged
merged 3 commits into from
Jan 17, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jan 16, 2020

Description

Don't unnecessarily relicense FindCUDAToolkit.cmake. As per recommendation in https://www.apache.org/legal/src-headers.html#3party

@roywei

#17329

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Don't unnecessarily relicense FindCUDAToolkit.cmake

@leezu leezu requested a review from szha as a code owner January 16, 2020 00:08
@leezu leezu requested a review from roywei January 16, 2020 00:08
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM! there is one typo

LICENSE Outdated Show resolved Hide resolved
@leezu leezu force-pushed the dontunnecessarilyrelicensefindcudatoolkit branch from 5ef4413 to 0b73ca0 Compare January 16, 2020 00:17
@leezu leezu merged commit 83b2891 into apache:master Jan 17, 2020
@leezu leezu deleted the dontunnecessarilyrelicensefindcudatoolkit branch January 17, 2020 13:23
leezu added a commit to leezu/mxnet that referenced this pull request Jan 17, 2020
https://www.apache.org/legal/src-headers.html#3party recommends to license small changes based on the original license. Thus I re-license my changes to FindCUDAToolkit.cmake under the BSD license used by CMake (see file header).
ptrendx pushed a commit that referenced this pull request Jan 17, 2020
https://www.apache.org/legal/src-headers.html#3party recommends to license small changes based on the original license. Thus I re-license my changes to FindCUDAToolkit.cmake under the BSD license used by CMake (see file header).
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
https://www.apache.org/legal/src-headers.html#3party recommends to license small changes based on the original license. Thus I re-license my changes to FindCUDAToolkit.cmake under the BSD license used by CMake (see file header).
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
https://www.apache.org/legal/src-headers.html#3party recommends to license small changes based on the original license. Thus I re-license my changes to FindCUDAToolkit.cmake under the BSD license used by CMake (see file header).
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
https://www.apache.org/legal/src-headers.html#3party recommends to license small changes based on the original license. Thus I re-license my changes to FindCUDAToolkit.cmake under the BSD license used by CMake (see file header).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants