This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix IOT Devices section of Get Started page #17326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing iot urlParam - Fix use of potentially undefined variables. For example, if the &processor= url parameter is unspecified, this would previously cause use of undefined variable javascript error leading to an empty page.
Codecov Report
@@ Coverage Diff @@
## master #17326 +/- ##
=======================================
Coverage 67.5% 67.5%
=======================================
Files 275 275
Lines 31227 31227
Branches 4721 4721
=======================================
Hits 21080 21080
Misses 8780 8780
Partials 1367 1367Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
url parameter is typically unspecified, causing use of undefined
variable javascript error leading to an empty page.
Example of broken IOT Devices section (Devices can't be selected)
Changes