Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix build from source instruction #17294

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

apeforest
Copy link
Contributor

Description

Need to add a blank line before bash section, otherwise the html page is not rendered properly
https://mxnet.apache.org/get_started/ubuntu_setup.html

  • break long lines
  • remove unnecesarry tab space
  • remove $ to make it consistent

@leezu @aaronmarkham please review.

@larroy
Copy link
Contributor

larroy commented Jan 14, 2020

Why do we have 2 build from source pages, this is all extremely confusing.

https://mxnet.apache.org/get_started/ubuntu_setup.html
https://mxnet.apache.org/get_started/build_from_source

@apeforest
Copy link
Contributor Author

Why do we have 2 build from source pages, this is all extremely confusing.

https://mxnet.apache.org/get_started/ubuntu_setup.html
https://mxnet.apache.org/get_started/build_from_source

This is out of scope of this PR. Please raise this in a seprate PR.

@leezu
Copy link
Contributor

leezu commented Jan 14, 2020

@larroy One page contains Ubuntu specific instructions, the other page contains generic instructions.
I think that's reasonable in principle, but the current instructions have a lot of room for simplification and improvement.

@leezu leezu merged commit 0efc0ca into apache:master Jan 14, 2020
@apeforest apeforest deleted the doc/fix_build branch January 14, 2020 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants