Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix lstm layer with projection save params #17266

Merged
merged 1 commit into from
Jan 11, 2020
Merged

fix lstm layer with projection save params #17266

merged 1 commit into from
Jan 11, 2020

Conversation

szha
Copy link
Member

@szha szha commented Jan 10, 2020

Description

fix lstm layer with projection save params

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add missing LSTMP weight in the the collect params regex in RNN layer

@eric-haibin-lin eric-haibin-lin merged commit c3b0baa into apache:master Jan 11, 2020
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 13, 2020
@szha @frankfliu
fix lstm layer with projection save params (apache#17266)
52fc0a3
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 13, 2020
@szha @frankfliu
fix lstm layer with projection save params (apache#17266)
9cd5bc6
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 13, 2020
@szha @frankfliu
fix lstm layer with projection save params (apache#17266)
ba03a36
haojin2 pushed a commit that referenced this pull request Jan 16, 2020
@frankfliu @szha @haojin2
fix lstm layer with projection save params (#17266) (#17288)
a003132 
Co-authored-by: Sheng Zha <[email protected]>
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 24, 2020
@szha @frankfliu
fix lstm layer with projection save params (apache#17266)
ecfcde8
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 31, 2020
@szha @frankfliu
fix lstm layer with projection save params (apache#17266)
44ca019
lanking520 pushed a commit that referenced this pull request Feb 3, 2020
@frankfliu @szha
fix lstm layer with projection save params (#17266) (#17286)
3b2bd99 
Co-authored-by: Sheng Zha <[email protected]>
@szha szha deleted the fix_lstmp_save branch April 26, 2020 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szha @eric-haibin-lin