Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[CD] fix CD pipeline #17259

Merged
merged 3 commits into from
Jan 14, 2020
Merged

[CD] fix CD pipeline #17259

merged 3 commits into from
Jan 14, 2020

Conversation

szha
Copy link
Member

@szha szha commented Jan 9, 2020

Description

fix CD pipeline

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • fix link time error from nccl by upgrading binutils
  • fix s3 command
  • fix failing mkldnn tests

Comments

  • cu90 is still failing due to multi-head attention tests

@@ -95,7 +95,7 @@ def __getitem__(self, key):
for _ in loader:
y = net(mx.nd.array(np.ones(X))).asnumpy()
# output should be 016711406 (non-mkldnn mode output)
assert_almost_equal(y[0, 0, 0, 0], 0.016711406)
assert_almost_equal(y[0, 0, 0, 0], np.array(0.016711406))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #17259 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17259      +/-   ##
==========================================
+ Coverage   67.51%   67.52%   +<.01%     
==========================================
  Files         275      275              
  Lines       31200    31200              
  Branches     4717     4717              
==========================================
+ Hits        21066    21068       +2     
+ Misses       8772     8771       -1     
+ Partials     1362     1361       -1
Impacted Files Coverage Δ
python/mxnet/image/image.py 76.2% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8accaca...0ac0fc5. Read the comment docs.

@szha szha merged commit 75b93bb into apache:master Jan 14, 2020
@szha szha deleted the fix_cd_s3 branch January 14, 2020 03:33
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 22, 2020
* fix CD pipeline

* fix s3 grants

* specify cuda version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants