Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add RandomApply in gluon's transforms #17242

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

guanxinq
Copy link
Contributor

@guanxinq guanxinq commented Jan 7, 2020

Description

Added RandomApply API in gluon's transforms which applies randomly a list of transformations with a given probability.
Unit test was added.
This fixes #17085.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@guanxinq guanxinq requested a review from szha as a code owner January 7, 2020 20:10
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@guanxinq guanxinq force-pushed the randomapply_dev branch 3 times, most recently from 69180de to d236d20 Compare January 15, 2020 23:48
@apeforest apeforest merged commit a63390d into apache:master Jan 16, 2020
@guanxinq guanxinq deleted the randomapply_dev branch January 16, 2020 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest to add RandomApply in gluon's transforms
3 participants