This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Additional fix for vector access. #17230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkcn
reviewed
Jan 7, 2020
| pp_A.reserve(batch_count); | ||
| pp_B.reserve(batch_count); | ||
| pp_C.reserve(batch_count); | ||
| std::vector<const double*> pp_A(batch_count, nullptr); |
There was a problem hiding this comment.
Thank you for the fix!
It will be faster to use std::vector<const double*> pp_A(batch_count); : )
There was a problem hiding this comment.
I did this because it's precisely the same logic used by the earlier commit.
That being said, I believe the STL guarantees that non-class types will be zero initialized when using the constructor form you propose, so I would expect the performance of the two forms to be identical.
|
Hi @aws-taylor , I could not retrigger the CI. Thank you! --edit: |
TaoLv
approved these changes
Feb 16, 2020
|
The PR has been merged. Thank you! |
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
* Additional fix for vector access. See apache@9634786 for the original. * CI * ci * ci * retrigger CI * ci Co-authored-by: JackieWu <[email protected]>
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* Additional fix for vector access. See apache@9634786 for the original. * CI * ci * ci * retrigger CI * ci Co-authored-by: JackieWu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 9634786 for the original.
Description
Fixes an assertion thrown by operator[] of std::vector when MxNet is compiled with certain STL hardening flags, especially since GCC 8. This pull request is to fix a small block that was missed in the original PR.