Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] loosen numpy version requirement #17200

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

reminisce
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@reminisce
Copy link
Contributor Author

@leezu

@leezu leezu merged commit 06aec8a into apache:master Jan 2, 2020
@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Jan 16, 2020

Wasn't numpy version restriction (<1.18) done to prevent numpy.decorator issue? @leezu @reminisce

@leezu
Copy link
Contributor

leezu commented Jan 16, 2020

It was also done due to #17154

That issue was fixed and no other failing tests found. Thus @reminisce loosened the requirement. Could you link the issue that tracks the remaining problems?

@ChaiBapchya
Copy link
Contributor

Any idea which PR should be merged to get 1.5.x into working?
I tried cherry-picking https://github.com/apache/incubator-mxnet/pull/17155/files but ran into merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants