Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix for gluon.Trainer regression with sparse grad on single context #17199

Merged
merged 1 commit into from
Jan 1, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Dec 31, 2019

Description

kvstore is None in single-context case. Assertion was wrongly triggered.
Fixes regression in #17010

@eric-haibin-lin

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix for gluon.Trainer regression with sparse grad on single context

Comments

@eric-haibin-lin

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@leezu leezu merged commit 8dee5b7 into apache:master Jan 1, 2020
@leezu leezu deleted the fixunifiedkvstore branch January 1, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants