Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Softmax primitive cache and in-place computation #17152

Merged
merged 4 commits into from
Jan 3, 2020

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Dec 23, 2019

Description

  1. softmax primitive is jitted now, hence cache it just like other primitives;
  2. softmax primitive supports in-place computation, hence no need to create additional intermediate memory.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv added the MKLDNN label Dec 23, 2019
@TaoLv TaoLv added this to In progress in CPU Performance and Quantization via automation Dec 26, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CPU Performance and Quantization automation moved this from In progress to Reviewer approved Dec 26, 2019
@pengzhao-intel pengzhao-intel merged commit 2a9ec0e into apache:master Jan 3, 2020
CPU Performance and Quantization automation moved this from Reviewer approved to Done Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants