Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Quantized Elemwise Mul Operator #17147

Merged
merged 12 commits into from
Dec 26, 2019
Merged

Conversation

xinyu-intel
Copy link
Contributor

Description

Add Quantized Elemwise Mul Operator for NCF further optimization.

  • support s8s8 inputs
  • support s32/s8/f32 output
  • may change to use dnnl primitive when dnnl v1.2 is ready.

@pengzhao-intel @TaoLv @ciyongch

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel pengzhao-intel added the Quantization Issues/Feature Requests related to Quantization label Dec 23, 2019
@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Dec 23, 2019
Copy link
Contributor

@ciyongch ciyongch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some tests to cover this new ops.

src/operator/quantization/quantized_elemwise_mul-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
@xinyu-intel
Copy link
Contributor Author

@ciyongch thx, please review again:)

Copy link
Contributor

@ciyongch ciyongch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need another simple test case to cover fusion pattern based on subgraph.

tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
src/operator/quantization/quantized_elemwise_mul.cc Outdated Show resolved Hide resolved
@xinyu-intel xinyu-intel changed the title [WIP] Quantized Elemwise Mul Operator Quantized Elemwise Mul Operator Dec 25, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ciyongch to review.

CPU Performance and Quantization automation moved this from In progress to Reviewer approved Dec 26, 2019
@pengzhao-intel pengzhao-intel merged commit cf81887 into apache:master Dec 26, 2019
CPU Performance and Quantization automation moved this from Reviewer approved to Done Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Quantization Issues/Feature Requests related to Quantization
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants