Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy ]Modify np.random.shuffle to enable inplace by default #17133

Merged
merged 2 commits into from
Dec 21, 2019

Conversation

xidulu
Copy link
Contributor

@xidulu xidulu commented Dec 20, 2019

Description

As title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@xidulu xidulu requested a review from szha as a code owner December 20, 2019 09:40
@xidulu xidulu changed the title Modify shuffle to enable inplace by default [Numpy ]Modify np.random.shuffle to enable inplace by default Dec 20, 2019
@haojin2 haojin2 self-assigned this Dec 21, 2019
@haojin2 haojin2 added the Numpy label Dec 21, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Dec 21, 2019
@haojin2 haojin2 merged commit d000c3b into apache:master Dec 21, 2019
numpy automation moved this from In progress to Done Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants