Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[CD] enable s3 publish for nightly builds in cd #17112

Merged
merged 3 commits into from
Dec 25, 2019
Merged

[CD] enable s3 publish for nightly builds in cd #17112

merged 3 commits into from
Dec 25, 2019

Conversation

szha
Copy link
Member

@szha szha commented Dec 18, 2019

Description

enable s3 publish for nightly builds in cd

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • enable publish to s3 from cd pipeline

@szha
Copy link
Member Author

szha commented Dec 18, 2019

@perdasilva @samskalicky @leezu

samskalicky
samskalicky approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, were you able to test this in ci-dev or some other way?

@szha szha merged commit 410165b into apache:master Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@marcoabreu marcoabreu marcoabreu left review comments

@samskalicky samskalicky samskalicky approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szha @leezu @samskalicky @marcoabreu