Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix trainer param order #17068

Merged
merged 4 commits into from
Dec 14, 2019
Merged

Conversation

eric-haibin-lin
Copy link
Member

Description

fixes #17056

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin
Copy link
Member Author

@szhengac

szha
szha previously requested changes Dec 13, 2019
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about dict support?

@eric-haibin-lin
Copy link
Member Author

Added back dict support

@szha szha dismissed their stale review December 14, 2019 01:12

addressed

@eric-haibin-lin eric-haibin-lin merged commit 696c547 into apache:master Dec 14, 2019
ptrendx pushed a commit to ptrendx/mxnet that referenced this pull request Dec 20, 2019
* fix trainer param order

* Update trainer.py

* Update trainer.py

* Update trainer.py
ptrendx added a commit that referenced this pull request Dec 20, 2019
* Improve the speed of the pointwise fusion graph pass (#17114)

* Debug the long startup time

* Optimize backward fusion

* Figure out why the fusion pass is called twice

* Cleaning

* Small optimization

* [BUGFIX] Fix trainer param order (#17068)

* fix trainer param order

* Update trainer.py

* Update trainer.py

* Update trainer.py

* [reproducibility] multi_sum_sq review, AtomicAdd removal (#17002)

* Update multi_sum_sq to avoid AtomicAdd

* Add specific test for multi_sum_sq

* Add a determism test and lint issues

* better test for cheching op is deterministic

* Follow MXNet letters case format

* Reduce dimensions of tensors in the test

Co-authored-by: Haibin Lin <[email protected]>
Co-authored-by: MoisesHer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gluon Trainer does not handle non-deterministic parameter order for distributed training
3 participants