Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Porting numpy-compatible hstack #17030

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Dec 10, 2019

Description

Numpy-compatible hstack was previously added in numpy branch #15302, porting the code to master branch now.
Also adding dstack for interoperability check.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • np.hstack op
  • unit tests and interoperability tests
  • interoperability tests for np.dstack

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Dec 10, 2019
@haojin2 haojin2 requested a review from szha as a code owner December 10, 2019 01:49
@haojin2 haojin2 self-assigned this Dec 10, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Dec 10, 2019
numpy automation moved this from In progress to Reviewer approved Dec 31, 2019
@haojin2 haojin2 force-pushed the np_hstack branch 2 times, most recently from 6c62f20 to bb0b1a6 Compare January 10, 2020 17:26
@haojin2 haojin2 merged commit 461f167 into apache:master Jan 13, 2020
numpy automation moved this from Reviewer approved to Done Jan 13, 2020
@haojin2 haojin2 deleted the np_hstack branch January 13, 2020 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants