This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix NDArrayIter cant pad when size is large #17001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkcn
reviewed
Dec 7, 2019
python/mxnet/io/io.py
Outdated
| if pad > self.num_data: | ||
| while True: | ||
| if pad <= self.num_data: | ||
| break | ||
| second_data = self._getdata(data_source, end=self.num_data) | ||
| second_data = self._concat(second_data, self._getdata(data_source, end=self.num_data)) |
There was a problem hiding this comment.
Can it be replaced with nd.repeat, in order to remove Python while-loop?
stu1130
force-pushed
the
fix_scala_env
branch
from
7d21b43
to
84d95df
Compare
wkcn
approved these changes
Dec 7, 2019
python/mxnet/io/io.py
Outdated
| @@ -709,23 +709,29 @@ def _getdata(self, data_source, start=None, end=None): | |||
|
|
|||
| def _concat(self, first_data, second_data): | |||
| """Helper function to concat two NDArrays.""" | |||
| if (not first_data) and (not second_data): | |||
| return [] | |||
| elif (not first_data) or (not second_data): | |||
There was a problem hiding this comment.
The four lines 712 to 715 could be replaced with the line 714 to 715.
if not first_data or not second_data:
return first_data if first_data else second_data
When first_data and second_data are both [], it will return [] too.
stu1130
force-pushed
the
fix_scala_env
branch
from
84d95df
to
a081fe6
Compare
roywei
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16996
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@samskalicky