Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix scala publish & nvidia-docker cublas issue #16968

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Dec 3, 2019

Description

Fixes two things

  1. libcuda.so.1 shoule be able to mapped by nvidia-docker, so we need to add --nvidiadocker when we publish scala package
  2. temporily downgrade the libcublas version as current nvidia-docker comes with wrong version of libcublas

Reference issue: NVIDIA/nvidia-docker#1143

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@stu1130 stu1130 changed the title fix scala pipeline Fix scala pipeline Dec 3, 2019
@stu1130 stu1130 changed the title Fix scala pipeline Fix libcuda.so.1 not found issue Dec 3, 2019
@stu1130 stu1130 force-pushed the fix_scala_pipeline branch 3 times, most recently from bec62b2 to c2d5833 Compare December 4, 2019 01:45
@stu1130 stu1130 changed the title Fix libcuda.so.1 not found issue Fix libcuda.so.1 not found in scala publish pipeline Dec 4, 2019
@stu1130 stu1130 force-pushed the fix_scala_pipeline branch 2 times, most recently from 869ef89 to 1dadeee Compare December 4, 2019 23:32
@stu1130 stu1130 changed the title Fix libcuda.so.1 not found in scala publish pipeline Fix scala publish & nvidia-docker cublas issue Dec 4, 2019
@wkcn wkcn merged commit edb583b into apache:master Dec 5, 2019
@wkcn
Copy link
Member

wkcn commented Dec 5, 2019

Great. Thank you for the fix : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants