Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update symbol to json #16948

Merged
merged 2 commits into from
Feb 16, 2020
Merged

update symbol to json #16948

merged 2 commits into from
Feb 16, 2020

Conversation

chinakook
Copy link
Contributor

add remove_amp_cast argument to keep same with symbol.save

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

add remove_amp_cast argument to keep same with symbol.save
@chinakook chinakook requested a review from szha as a code owner November 29, 2019 10:39
@szha szha requested a review from ptrendx November 30, 2019 00:08
@chinakook
Copy link
Contributor Author

@ptrendx

@chinakook
Copy link
Contributor Author

@szha

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix : )

Hi @chinakook , I could't retrigger the CI.
Could you please retrigger it (push an empty commit) ?
Thank you!

--edit:
I have re-triggered it.

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 16, 2020
@wkcn wkcn merged commit 9c10ed4 into apache:master Feb 16, 2020
@wkcn
Copy link
Member

wkcn commented Feb 16, 2020

Merged. Thank you for the contribution!

zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
* update symbol to json

add remove_amp_cast argument to keep same with symbol.save

* retrigger CI

Co-authored-by: JackieWu <[email protected]>
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* update symbol to json

add remove_amp_cast argument to keep same with symbol.save

* retrigger CI

Co-authored-by: JackieWu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants