Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Try to fix CI #16908

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Try to fix CI #16908

merged 2 commits into from
Nov 26, 2019

Conversation

sxjscience
Copy link
Member

@sxjscience sxjscience commented Nov 26, 2019

Description

It looks that this issue #16815 is blocking the CI.

Revised based on the error message in http:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16902/4/pipeline

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I'd appreciate if you could bisect and find out which PR introduced the issue and find out how it was possible to merge it while having missing dependencies. Something seems off.

@sxjscience
Copy link
Member Author

@marcoabreu I’m also wondering how this would ever be possible. I guest it’s due to some internal update of the CI machines.

@marcoabreu
Copy link
Contributor

The environment is fully dockerized, so changes on the CI machines shouldn't impact it as far as I know

@sxjscience sxjscience merged commit a11b7ea into apache:master Nov 26, 2019
@larroy
Copy link
Contributor

larroy commented Nov 26, 2019

this could be a ccache cache issue. I can't reproduce locally. TVM lib seems corrupted.

@larroy
Copy link
Contributor

larroy commented Nov 26, 2019

If this change is not fixing the failure, could we revert it if the additional deps are not needed?

@larroy
Copy link
Contributor

larroy commented Nov 26, 2019

#16478 (comment)

@sxjscience
Copy link
Member Author

@larroy Yes, we should revert it

sxjscience added a commit to sxjscience/mxnet that referenced this pull request Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants