Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

updating MXNet version to 1.6.0 in base.h for C APIs #16905

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

access2rohit
Copy link
Contributor

Description

updating MXNet version to 1.6.0 in base.h for C APIs
#16904

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)

@access2rohit
Copy link
Contributor Author

@lanking520

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a key problem with the publish, we should bump it once we make the release

@access2rohit
Copy link
Contributor Author

This is a key problem with the publish, we should bump it once we make the release

yes

@access2rohit
Copy link
Contributor Author

@ptrendx

@samskalicky
Copy link
Contributor

@access2rohit shouldnt we be changing master to 1.7?

@access2rohit
Copy link
Contributor Author

?

@samskalicky Sure! I think we should first bump master to 1.6 and then again to 1.7. Does that makes sense ?

@ptrendx
Copy link
Member

ptrendx commented Nov 26, 2019

@access2rohit Since the 1.6.x branch is already diverged from master, there is no need to do this 1.6 step I think - we should just go directly to 1.7 (which I believe requires changes in more places).

@access2rohit
Copy link
Contributor Author

@access2rohit Since the 1.6.x branch is already diverged from master, there is no need to do this 1.6 step I think - we should just go directly to 1.7 (which I believe requires changes in more places).

Yes it requires changes in more places. IMO we should follow proper progression by moving from 1.5->1.6->1.7 to keep the change history in master clean and consistent.
@ptrendx do you agree ?

Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm fine with this change first.

@zachgk zachgk merged commit fcc42de into apache:master Dec 6, 2019
eric-haibin-lin pushed a commit to eric-haibin-lin/mxnet that referenced this pull request Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants