Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Fix imperative basic indexing in numpy #16902

Merged
merged 3 commits into from
Nov 26, 2019
Merged

[Numpy] Fix imperative basic indexing in numpy #16902

merged 3 commits into from
Nov 26, 2019

Conversation

sxjscience
Copy link
Member

@sxjscience sxjscience commented Nov 25, 2019 •
edited
Loading

Description

Fix #16887

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Bugfix basic indexing in numpy ndarray, test

@sxjscience
Copy link
Member Author

@ptrendx @reminisce I've split the bugfix in this PR.

@sxjscience
fix bug
8f26fe6 
add test case

fix

Update test_numpy_ndarray.py
@haojin2 haojin2 added the Numpy label Nov 25, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Nov 25, 2019
@haojin2 haojin2 self-assigned this Nov 25, 2019
@sxjscience sxjscience mentioned this pull request Nov 26, 2019
Merged
9 tasks
@ptrendx
Copy link
Member

ptrendx commented Nov 26, 2019

@sxjscience I'm confused. The issue tagged 1.6.0 is #16887 and I thought you will make the separate fix for that issue, not #16279...

@sxjscience
Copy link
Member Author

@ptrendx Sorry for the confusion. This one actually fixes #16887.... I've mistakenly pointed to the other one.

@ptrendx ptrendx added the R1.6.0 label Nov 26, 2019
numpy automation moved this from In progress to Reviewer approved Nov 26, 2019
haojin2
haojin2 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 8f10d55 into apache:master Nov 26, 2019
numpy automation moved this from Reviewer approved to Done Nov 26, 2019
ptrendx pushed a commit to ptrendx/mxnet that referenced this pull request Nov 27, 2019
@sxjscience @ptrendx
[Numpy] Fix imperative basic indexing in numpy (apache#16902)
c7f819b 
* fix bug

add test case

fix

Update test_numpy_ndarray.py

* revise function name
@ptrendx ptrendx mentioned this pull request Nov 27, 2019
Merged
ptrendx added a commit that referenced this pull request Nov 27, 2019
@ptrendx
[Numpy] Fix imperative basic indexing in numpy (#16902) (#16919)
a3b0aa4 
* fix bug

add test case

fix

Update test_numpy_ndarray.py

* revise function name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy R1.6.0
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Numpy] Bug of basic indexing
3 participants
@sxjscience @ptrendx @haojin2