Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adding user guidelines for using MXNet built with Large Tensor Support #16894

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Nov 24, 2019

Description

Doc that layouts brief guidelines regarding how to use MXNet build with Large Tensor Support

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete


Not supported:

* GPU and MKLDNN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows? Arm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Ubuntu. Will add that

* Other language bindings like Scala, Java, R, and Julia.

## Performance Regression:
Roughly 40 operators have shown performance regression in our preliminary analysis: Large Tensor Performance (https://docs.google.com/spreadsheets/d/1GpdNquQb71Is5B-li99JDuiLeEZd-eSjHIIowzGrwxc/edit#gid=1325641791)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a Google docs document is not necessarily persistent, can we maybe add a spoiler or something like that (does our mark-up support it?)

Alternatively, we could just add it as attachment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoabreu I didn't understand your point about google docs not being persistent. Also, can you tell me how can I add this excel sheet as attachment to the codebase ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@access2rohit How about exporting it to csv, then converting it to md with this tool? http:https://www.convertcsv.com/csv-to-markdown.htm
Then you can add it to this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is it's a big csv (400+ lines) so converting this to csv -> md and then adding it to this file will bloat the file (and won't look good with 400 lines)
What would you suggest in that case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is it's a big csv (400+ lines) so converting this to csv -> md and then adding it to this file will bloat the file (and won't look good with 400 lines)
What would you suggest in that case?

I thought it was just a list of 40. I see now that it has several sheets too. I'd leave it in excel format. What if you just upload a .xls file? I'm not sure of the best alternative here. If the person that has the file in the google drive deletes their account, the file is gone forever, so I agree it probably shouldn't live there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@access2rohit access2rohit changed the title [WIP]Adding user guidelines for using MXNet built with Large Tensor Support Adding user guidelines for using MXNet built with Large Tensor Support Nov 25, 2019
@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Nov 25, 2019
@access2rohit
Copy link
Contributor Author

@aaronmarkham PR is ready for review

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retriggered unix-cpu (failed for unrelated clojure related network issue (known))
Rest LGTM ;)

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 27, 2019
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 32a9baa into apache:master Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants